Skip to content

feat(textarea): added highlight and focus styles to ionic theme #30062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 9, 2024
Merged

feat(textarea): added highlight and focus styles to ionic theme #30062

merged 10 commits into from
Dec 9, 2024

Conversation

@BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Dec 5, 2024 •
edited
Loading

Issue number: internal

What is the new behavior?

  • Fixed highlight validation to include ionic theme
  • Added styles on ionic scss partial for focus and highlight
  • Added focus state test to textarea

Does this introduce a breaking change?

  • Yes
  • No

Other information

@BenOsodrac BenOsodrac added type: feature request a new feature, enhancement, or improvement package: core @ionic/core package labels Dec 5, 2024
@vercel
Copy link

vercel bot commented Dec 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:47am

@BenOsodrac BenOsodrac marked this pull request as ready for review December 5, 2024 16:16
@BenOsodrac BenOsodrac requested a review from a team as a code owner December 5, 2024 16:16
tanner-reits
tanner-reits approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@tanner-reits tanner-reits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thetaPC thetaPC requested review from brandyscarney and removed request for thetaPC December 6, 2024 20:03
@BenOsodrac BenOsodrac merged commit 805b75a into next Dec 9, 2024
46 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11444 branch December 9, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

+1 more reviewer

@tanner-reits tanner-reits tanner-reits approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: core @ionic/core package type: feature request a new feature, enhancement, or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BenOsodrac @brandyscarney @tanner-reits